Skip to content

Conversation

Anshumancanrock
Copy link
Contributor

@Anshumancanrock Anshumancanrock commented Oct 6, 2025

📌 Fixes

Fixes #252


📝 Summary of Changes

This PR removes the unused and empty background service worker from the extension to improve performance and code cleanliness.

Changes made:

  • Removed the "background" section from src/manifest.json that declared an empty service worker
  • Deleted the empty src/scripts/background.js file from the repository

Impact:

  • Faster extension loading time (no empty worker to initialize)
  • Reduced resource usage
  • Cleaner codebase with no unused files
  • No confusion

✅ Checklist

  • I've tested my changes locally
  • I've added tests (if applicable)
  • I've updated documentation (if applicable)
  • My code follows the project's code style guidelines
  • The extension loads and functions correctly in Chrome/Firefox
  • No console errors or warnings appear
  • All existing features continue to work as expected
  • The manifest.json follows Manifest V3 standards

@github-actions github-actions bot added the javascript Pull requests that update javascript code label Oct 6, 2025
@Anshumancanrock
Copy link
Contributor Author

@vedansh-5 Kindly review this PR sir and let me know if you want any changes. Thank you!

Copy link
Member

@vedansh-5 vedansh-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm @hpdang! Thanks @Anshumancanrock for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] : Empty Background Service Worker Declaration

2 participants