Skip to content

Conversation

@Dishebh
Copy link
Member

@Dishebh Dishebh commented Dec 15, 2019

  • Included a Preview link and screenshot showing after and before the changes.
  • Included a description of the change below.
  • Squashed the commits.

Changes done in this Pull Request

Description / Changes

Fixed the page responsiveness issue by aligning each card a specific a height.

Screenshots if any:

Before:

issue1
issue2

After:

Screenshot from 2019-12-16 01-42-55
Screenshot from 2019-12-16 01-43-02


@Dishebh Dishebh closed this Dec 15, 2019
@Dishebh Dishebh reopened this Dec 15, 2019
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview Link not working.

@Dishebh
Copy link
Member Author

Dishebh commented Dec 23, 2019

@mariobehling here's the preview link:
https://dishebh.github.io/summit.fossasia.org/

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes result in increased white area. Unused white space in some rows now.

Screenshot from 2019-12-23 12-36-32

@Dishebh
Copy link
Member Author

Dishebh commented Dec 23, 2019

@mariobehling
Copy link
Member

Does not look like the right approach. I think we can just shorten the text. I will work on this in a bit.

@Dishebh
Copy link
Member Author

Dishebh commented Dec 23, 2019

Cool, just let me know if I can help somehow, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Page Responsiveness

2 participants