Skip to content

Update cfwhile.json #1696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

scallahan-dev
Copy link
Contributor

Added support for ColdFusion for the script syntax as well as a script syntax example.

Added support for ColdFusion for the script syntax as well as a script syntax example.
@pfreitag
Copy link
Member

pfreitag commented Apr 3, 2025

Hi @scallahan-dev thanks for your contribution. I would prefer to keep the coldfusion key out of the engines struct in this case since the tag is not supported on CF the omission implies this and it will display a message.

Would love to have your cfscript while loop example in there though, so if you want to update the PR to include just that, I'd gladly accept that.

@scallahan-dev
Copy link
Contributor Author

@pfreitag That makes since, but the notice on the page is confusing and doesn't indicate anywhere that the script syntax is valid for ColdFusion. I'm open to ideas on how to make this more apparent.

@pfreitag
Copy link
Member

pfreitag commented Apr 3, 2025

Yes, good point -- maybe in your example you can mention in the description of your example that the script syntax works on both Adobe ColdFusion and Lucee

Script syntax with break usage and include a note of compatibility with ColdFusion.
@scallahan-dev
Copy link
Contributor Author

@pfreitag New commit with your requested changes.

@scallahan-dev
Copy link
Contributor Author

@pfreitag Just wanted to see if there were any other changes you wanted made to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants