Skip to content

Run tests through blockifier logic #3238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Run tests through blockifier logic #3238

wants to merge 1 commit into from

Conversation

cptartur
Copy link
Member

@cptartur cptartur commented Apr 18, 2025 •
edited
Loading

@cptartur cptartur requested a review from a team as a code owner April 18, 2025 10:48
@cptartur cptartur requested review from ddoktorski and kkawula and removed request for a team April 18, 2025 10:48
This was referenced Apr 18, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
@cptartur cptartur force-pushed the spr/master/2777abe1 branch 4 times, most recently from 88e1ed8 to cd3afef Compare April 22, 2025 14:47
franciszekjob
franciszekjob reviewed Apr 24, 2025
View reviewed changes
ddoktorski
ddoktorski reviewed Apr 24, 2025
View reviewed changes
@cptartur cptartur force-pushed the spr/master/2777abe1 branch from cd3afef to 95993b7 Compare April 28, 2025 15:09
@cptartur cptartur force-pushed the spr/master/a9dfa87d branch from 7f2638f to 156a1fe Compare April 28, 2025 15:09
@franciszekjob
Copy link
Contributor

@cptartur please re-request review once tests are fixed 🙏

@cptartur cptartur force-pushed the spr/master/2777abe1 branch from 95993b7 to 737445f Compare April 30, 2025 14:14
github-merge-queue bot pushed a commit that referenced this pull request Apr 30, 2025
@cptartur
Refactor running related code (#3237)
bb6eed8 
commit-id:a9dfa87d

---

**Stack**:
- #3247
- #3246
- #3245
- #3244
- #3243
- #3242
- #3241
- #3240
- #3239
- #3238
- #3237 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
Base automatically changed from spr/master/a9dfa87d to master April 30, 2025 16:32
@cptartur
Copy link
Member Author

cptartur commented May 7, 2025

@cptartur please re-request review once tests are fixed 🙏

@franciszekjob you can re-review, tests pass eventually in the final PR.

ddoktorski
ddoktorski reviewed May 8, 2025
View reviewed changes
@cptartur cptartur force-pushed the spr/master/2777abe1 branch from 737445f to 76079bb Compare May 9, 2025 10:22
@cptartur cptartur requested a review from ddoktorski May 9, 2025 10:23
@cptartur cptartur force-pushed the spr/master/2777abe1 branch 2 times, most recently from 0aebfcd to 4c1a1a0 Compare May 9, 2025 13:59
@cptartur cptartur force-pushed the spr/master/2777abe1 branch from 4c1a1a0 to ba5ec99 Compare May 12, 2025 09:27
This was referenced May 12, 2025
Closed
Closed
@cptartur cptartur force-pushed the spr/master/2777abe1 branch from ba5ec99 to 9e1f10a Compare May 12, 2025 15:27
@cptartur cptartur mentioned this pull request May 12, 2025
Merged
@cptartur cptartur force-pushed the spr/master/2777abe1 branch from 9e1f10a to f4f251f Compare May 13, 2025 13:40
@cptartur cptartur mentioned this pull request May 13, 2025
Closed
@cptartur cptartur force-pushed the spr/master/2777abe1 branch from f4f251f to 90ab202 Compare May 14, 2025 12:14
@cptartur cptartur force-pushed the spr/master/2777abe1 branch from 90ab202 to 58ce8b9 Compare May 14, 2025 15:25
@cptartur
Copy link
Member Author

✓ Commit merged in pull request #3333

@cptartur cptartur closed this May 15, 2025
github-merge-queue bot pushed a commit that referenced this pull request May 15, 2025
@cptartur
Update the copied code to reflect what will be upstreamed to blockifi…
d837fd3 
…er (#3333)

commit-id:886e564f

---

**Stack**:
- #3333 ⬅
- #3328
- #3327
- #3247
- #3246
- #3245
- #3244
- #3243
- #3242
- #3241
- #3240
- #3238


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotmag769 piotmag769 piotmag769 left review comments

@ddoktorski ddoktorski ddoktorski approved these changes

@franciszekjob franciszekjob franciszekjob approved these changes

@kkawula kkawula Awaiting requested review from kkawula kkawula is a code owner automatically assigned from foundry-rs/starknet-foundry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cptartur @franciszekjob @ddoktorski @piotmag769 @kkawula