Escaping newlines in Log viewer buffer (#2119)

fox0430 · Jul 28, 2024 · 99b1973 · 99b1973
1 parent 0d395b7
commit 99b1973
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 2 deletions.
diff --git a/changelog.d/20240727_235752_github-actions[bot]_newline-in-logviewer.rst b/changelog.d/20240727_235752_github-actions[bot]_newline-in-logviewer.rst
@@ -0,0 +1,7 @@
+.. _#2119:  https://github.com/fox0430/moe/pull/2119
+
+Fixed
+.....
+
+- `#2119`_ Escaping newlines in Log viewer buffer
+
diff --git a/src/moepkg/logviewerutils.nim b/src/moepkg/logviewerutils.nim
@@ -43,8 +43,8 @@ proc initEditorLogViewrBuffer*(): seq[Runes] =
   if log.len == 0:
     return @[ru""]
 
-  for i, l in log:
-    result.add l
+  for i, line in log:
+    for l in line.splitLines: result.add l
     if i < log.high:
       result.add ru""
 

diff --git a/tests/tlogviewerutils.nim b/tests/tlogviewerutils.nim
@@ -57,6 +57,19 @@ suite "logviewerutils: initEditorLogViewrBuffer":
     ]
     .toSeqRunes
 
+  test "With new line":
+    addMessageLog "line1.0\nline1.1"
+    addMessageLog "line2.0\nline2.1"
+
+    check initEditorLogViewrBuffer() == @[
+      "line1.0",
+      "line1.1",
+      "",
+      "line2.0",
+      "line2.1"
+    ]
+    .toSeqRunes
+
 suite "logviewerutils: initLspLogViewrBuffer":
   setup:
     clearMessageLog()