Prelude extension

[wojpok]

This PR is part of #256 separated for easier merging and review

[ppolesiuk]

Looks good. I would consider defining min and max functions for any type with comparison.

[ppolesiuk]

Is there any reason to define this function for Int type only? Maybe we can define a more polymorphic version for any type with lt method.

Suggested change

	pub let max (x : Int) (y : Int) =
	if x > y then x else y
	pub let max {T, method lt : T -> T ->> Bool} (x : T) (y : T) =
	if x < y then y else x

BTW, we could add also min function, and provide some documentation for them.

[ppolesiuk]

Is there any reason to implement min and max functions on top of different comparison methods (lt and gt, respectively)? Both implementation can be based on lt method.

Suggested change

	pub let min {T, method gt : T -> T ->> Bool} (x : T) (y : T) =
	if x > y then y else x
	pub let min {T, method lt : T -> T ->> Bool} (x : T) (y : T) =
	if x < y then x else y

[wojpok]

I thought that it would be more accurate to return the first element when elements are equal. It may be not necessary. I will remove this later

[ppolesiuk]

Suggested change

	pub let min {T, method gt : T -> T ->> Bool} (x : T) (y : T) =
	if x > y then y else x
	pub let min {T, method gt : T -> T ->> Bool} (x : T) (y : T) =
	if y < x then y else x

?

[wojpok]

Yeah, right, my bad 😅

[wojpok]

Both min and max use lt method. Implementation have been supported with appropriate tests

[Copilot]

Pull Request Overview

This PR extends the Prelude library with additional utility functions and methods, supporting issue #256.

• Adds min and max functions for comparable types
• Adds strListCat for efficient string concatenation and replicate for string repetition
• Exposes fst and snd as tuple methods
• Adds map method to Option type

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
lib/Prelude.fram	Adds fst/snd methods, min/max comparison functions, strListCat extern, and replicate string utility
lib/Base/Option.fram	Adds map method for functional transformation of Option values
test/stdlib/stdlib0006_Prelude.fram	New test file covering min, max, strListCat, and replicate functions
test/stdlib/stdlib0001_Option.fram	Adds test case for the new map method on Option type

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[ppolesiuk]

Copilot have found some minor mistakes in comments, and its suggestions looks reasonable. If these things will be fixed, the PR will be ready for merge.

[wojpok]

I have applied all suggestions directly

[Copilot]

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Inconsistent indentation: this line uses one space for indentation while the previous code uses two spaces. Should be indented with two spaces to match the rest of the file.

Suggested change

	(let s' = replicate s (n / 2) in
	s' + s')
	else
	(let s' = replicate s (n / 2) in
	(let s' = replicate s (n / 2) in
	s' + s')
	else
	(let s' = replicate s (n / 2) in

[Copilot]

Inconsistent indentation: this line uses one space for indentation while the previous code uses two spaces. Should be indented with two spaces to match the rest of the file.

Suggested change

	(let s' = replicate s (n / 2) in
	(let s' = replicate s (n / 2) in