Skip to content

Conversation

@wojpok
Copy link
Collaborator

@wojpok wojpok commented Feb 9, 2026

No description provided.

@wojpok
Copy link
Collaborator Author

wojpok commented Feb 9, 2026

The randomized test is really resource heavy. I had to increase the timeout to fit this in. Since we are going to replace this script soon, I think this temporary solution is sufficient

Copy link
Member

@ppolesiuk ppolesiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

export DBL_LIB="lib/"

TIMEOUT=1.0
TIMEOUT=3.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The timeout should be increased selectively, only for stdlib tests. For functional tests, it's better to keep it small, as tested programs are very tiny. However, we can fix it once #312 will be merged.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the stdlib Map tests by migrating them from a standalone simple_test file into the shared Testing-framework-based stdlib test suite, and adjusts the test runner timeout to accommodate the randomized Map test.

Changes:

  • Remove the legacy Map test file from the test/test_suite runner and delete test/stdlib/stdlib0008_Map.fram.
  • Add new test/stdlib/Map.fram using the Testing framework and include it in test/stdlib/TestAll.fram.
  • Increase test.sh per-test timeout from 1s to 3s.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/test_suite Stops running the removed legacy Map test file directly.
test/stdlib/stdlib0008_Map.fram Deletes the old standalone Map test.
test/stdlib/TestAll.fram Imports the new test/stdlib/Map.fram module so its tests run under the stdlib test aggregation.
test/stdlib/Map.fram Reintroduces Map coverage using Testing’s testSuite/testCase structure, including the prior randomized test logic.
test.sh Raises the timeout to reduce false failures from longer-running tests (notably randomized ones).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ppolesiuk ppolesiuk merged commit d2f2bb4 into fram-lang:master Feb 9, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants