Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive tutorial documentation for the Fram language's module system, covering basic to advanced features.
Changes:
- Added complete module system documentation covering basic module definition, nesting, file organization, and visibility controls
- Documented advanced features including abstract members, module inclusion, method visibility, and named parameter packing/unpacking
- Included practical examples demonstrating functors using existential types
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| In the above example, the variables `foo`, `a`, `b`, and `c` are public | ||
| members of the module, while `bar` and `x` are private. The last line is | ||
| technically correct, but it is not recommended to use `pub` in this way. |
There was a problem hiding this comment.
The phrase "technically correct" is vague in documentation. Consider replacing with more precise language that explains why this pattern works but should be avoided, such as "This pattern is valid but not recommended" or simply "This is not recommended".
| technically correct, but it is not recommended to use `pub` in this way. | |
| valid but not recommended, and it is better to avoid using `pub` in this way. |
forell
left a comment
forell
left a comment
There was a problem hiding this comment.
Looks pretty much perfect in terms of narration and content.
No description provided.