Use GetOkExists for price amounts #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for a `0` price to be set as a price `amount` in Stripe. `GetOk` considers `0` as a null value for integers, because it's unclear whether it was intentionally set or unset. `GetOkExists` allows us to get whatever value was set, even if it's `0`. Fixes franckverrot#42
|
Hi, that works for me! Could you please check if you can add this to the next release? |
|
@franckverrot what do you think of this fix? |
|
This fix would be great. @franckverrot could we get this reviewed and merged? |
|
I am also waiting on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for a
0price to be set as a priceamountin Stripe.GetOkconsiders0as a null value for integers, because it's unclear whether it was intentionally set or unset.GetOkExistsallows us to get whatever value was set, even if it's0.Fixes #42