Skip to content

fix(site-config-key): Add hint for max_file_size#6506

Open
balamurali27 wants to merge 2 commits into
developfrom
max-file-size
Open

fix(site-config-key): Add hint for max_file_size#6506
balamurali27 wants to merge 2 commits into
developfrom
max-file-size

Conversation

@balamurali27

@balamurali27 balamurali27 commented May 25, 2026

Copy link
Copy Markdown
Contributor

Add site config key to fixtures to make updates to these keys persist

@balamurali27 balamurali27 requested a review from ssiyad as a code owner May 25, 2026 09:39
@balamurali27 balamurali27 changed the title max file size fix(site-config-key): Add hint for max_file_size May 25, 2026
@greptile-apps

greptile-apps Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes the press/fixtures/site_config_key.json file entirely. The commit message clarifies that Site Config Key was removed from hooks.py long ago, meaning the fixture was never automatically applied; production currently has ~274 keys while the file contained only 55, so it was stale and misleading.

  • Dead fixture removed: site_config_key.json is not referenced in press/hooks.py's fixtures list, confirming it was never loaded during bench migrate or bench import-fixtures.
  • PR metadata mismatch: The PR title and description say "Add hint for max_file_size" but the actual commit (message: "Remove fixture") deletes the entire file — the title appears to be from a previous iteration of this fix.

Confidence Score: 5/5

Safe to merge — this removes a fixture file that was never wired into the app's fixture loading mechanism.

The deleted file was not listed in hooks.py's fixtures array, so it was never automatically imported during deploys or migrations. Removing it has no runtime impact and eliminates a stale, incomplete snapshot (55 entries vs ~274 in production) that could have caused confusion if ever run manually.

No files require special attention; the sole changed file is a now-unused fixture being cleaned up.

Important Files Changed

Filename Overview
press/fixtures/site_config_key.json Entire fixture file deleted — Site Config Key is not listed in hooks.py fixtures, so this was dead/unreferenced data; removal is correct cleanup.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[bench migrate / import-fixtures] --> B{Is doctype in hooks.py fixtures list?}
    B -- Yes --> C[Fixture file is loaded & applied]
    B -- No --> D[Fixture file is ignored]
    D --> E["site_config_key.json was here\n(never loaded — not in hooks.py)"]
    E --> F[File deleted in this PR ✓]
    C --> G["Other fixtures: Site Plan, Server Plan,\nMariaDB Variable, etc."]
Loading

Reviews (2): Last reviewed commit: "fix(site-config-key): Remove fixture" | Re-trigger Greptile

@codecov

codecov Bot commented May 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.09%. Comparing base (4f65495) to head (f955b8f).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
press/press/doctype/site/site.py 28.57% 5 Missing ⚠️

❌ Your patch check has failed because the patch coverage (28.57%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6506      +/-   ##
===========================================
- Coverage    50.10%   50.09%   -0.01%     
===========================================
  Files          954      954              
  Lines        78842    78849       +7     
  Branches       368      369       +1     
===========================================
- Hits         39500    39498       -2     
- Misses       39316    39325       +9     
  Partials        26       26              
Flag Coverage Δ
dashboard 61.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

It not in hooks.py for a long time. Prod has 274 keys. Fixture only has
55. No point keeping this fixture.

Also updating doc is pointless as they get overridden by fixture if the
doc is present in fixture
@balamurali27 balamurali27 reopened this May 26, 2026
@balamurali27 balamurali27 requested a review from tanmoysrt as a code owner May 26, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant