fix(site-config-key): Add hint for max_file_size#6506
Conversation
|
| Filename | Overview |
|---|---|
| press/fixtures/site_config_key.json | Entire fixture file deleted — Site Config Key is not listed in hooks.py fixtures, so this was dead/unreferenced data; removal is correct cleanup. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[bench migrate / import-fixtures] --> B{Is doctype in hooks.py fixtures list?}
B -- Yes --> C[Fixture file is loaded & applied]
B -- No --> D[Fixture file is ignored]
D --> E["site_config_key.json was here\n(never loaded — not in hooks.py)"]
E --> F[File deleted in this PR ✓]
C --> G["Other fixtures: Site Plan, Server Plan,\nMariaDB Variable, etc."]
Reviews (2): Last reviewed commit: "fix(site-config-key): Remove fixture" | Re-trigger Greptile
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (28.57%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #6506 +/- ##
===========================================
- Coverage 50.10% 50.09% -0.01%
===========================================
Files 954 954
Lines 78842 78849 +7
Branches 368 369 +1
===========================================
- Hits 39500 39498 -2
- Misses 39316 39325 +9
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4fb3b27 to
bfaf852
Compare
It not in hooks.py for a long time. Prod has 274 keys. Fixture only has 55. No point keeping this fixture. Also updating doc is pointless as they get overridden by fixture if the doc is present in fixture
Also suggest alternative
Add site config key to fixtures to make updates to these keys persist