feat(ci): Improve test coverage

[saurabh6790]

Greptile Summary

This PR expands test coverage across 10 doctypes, adding hundreds of new test cases for site status transitions, app release lifecycle, approval request workflows, cluster provisioning, team RBAC, deploy-candidate build pipeline, and the can_use_release gate.

• New tests cover failure/success paths for process_restore_job_update, process_migrate_site_job_update, AppReleaseApprovalRequest status propagation, Hetzner/AWS API error handling, VirtualMachine volume helpers, server-creation routing, and team-member permission guards.
• Shared test infrastructure is added (user_context, get_current_team_ctx, _patch_sync_press_role, _make_cluster, etc.) to support RBAC and multi-cloud scenarios without hitting live APIs.

Confidence Score: 5/5

Safe to merge — this PR adds only test code and a timestamp update to the secrets baseline; no production logic is changed.

All changed files are test files. The new tests correctly mirror the production implementations they exercise (verified against site.py, release_group.py, and app_release_approval_request.py). Mock usage is appropriate throughout, with two minor cases where the mocking strategy could be tightened for long-term reliability, but neither represents a functional defect today.

No files require special attention. The two observations are in test_agent_job.py (broad frappe.db.get_value mock) and test_release_group.py (trivially-true assertion), both non-blocking.

Important Files Changed

Filename	Overview
press/press/doctype/agent_job/test_agent_job.py	Adds tests for Restore Site and Migrate Site job status transitions; one test patches frappe.db.get_value globally rather than scoping the mock to the specific call.
press/press/doctype/release_group/test_release_group.py	Adds can_use_release unit tests and deploy-blocking integration tests; one test assertion is trivially true and only acts as a smoke test.
press/press/doctype/app_release/test_app_release.py	Adds comprehensive before_save, _has_auto_deploy_marker, has_permission, and set_invalid tests; duplicate AppRelease import under TYPE_CHECKING already flagged in a prior review thread.
press/press/doctype/app_release_approval_request/test_app_release_approval_request.py	New test file covering guard conditions, status propagation on_update, and auto-approval in before_save; correctly patches after_insert to avoid audit-creation side effects.
press/press/doctype/app_release_difference/test_app_release_difference.py	New test file for is_migrate_needed file classification, validate constraints, and has_branch_changed helper; well-structured and correct.
press/press/doctype/cluster/test_cluster.py	Large addition covering cluster validation, firewall normalisation, server-creation guards, Hetzner/AWS failure paths, NAT server logic, VirtualMachine volume helpers, and server routing.
press/press/doctype/team/test_team.py	Adds extensive RBAC tests (owner/admin detection, member permission guards, invite flows, Press Role management) with robust user_context and get_current_team_ctx helpers.
press/press/doctype/deploy_candidate_build/test_deploy_candidate_build.py	Adds build pipeline unit tests: Dockerfile encoding, checkpoint extraction, distutils support check, and pre-build step generation.
press/press/doctype/site/test_site.py	Adds tenancy safeguard tests: app-not-on-bench, frappe-first-app enforcement, duplicate-app detection, and server-script-on-public-bench guard.
press/press/doctype/app_source/test_app_source.py	Adds source signature, duplicate version, required-app URL parsing, and private repo token tests; all well-structured.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Agent Job Status Update] --> B{job_type}
    B -->|Restore Site| C[process_restore_job_update]
    B -->|Migrate Site| D[process_migrate_site_job_update]

    C --> E{job.status}
    E -->|Success| F[Site → Active\nset_apps + marketplace hooks]
    E -->|Failure| G[Site → Broken\nset creation_failed]
    E -->|Delivery Failure| H[Site → Active]
    E -->|Running| I[Site → Installing]

    D --> J{job.status}
    J -->|Failure| K[Site → Broken]
    J -->|Running| L[Site → Updating]

    subgraph AppRelease Lifecycle
        M[before_insert] --> N[update_release_status → Awaiting Approval]
        O[on_update: Approved] --> P[AppRelease → Approved]
        Q[on_update: Rejected] --> R[AppRelease → Rejected]
        S[cancel] --> T[AppRelease → Draft]
    end

    subgraph can_use_release Gate
        U{app_release.public?} -->|No| V[Always usable]
        U -->|Yes| W{status}
        W -->|Approved / Draft| X[Usable]
        W -->|Awaiting / Rejected / Yanked| Y[Blocked]
    end

Loading

_{Reviews (3): Last reviewed commit: "fix(test): remove spurious .name access ..." | Re-trigger Greptile}

[greptile-apps]

Greptile Summary

This PR significantly expands test coverage across 47 files, adding roughly 8 000 lines of new test code across doctypes including Team, Server, Cluster, Virtual Machine, Deploy Candidate, Site, and many more. The only production code change refactors set_dedicated_server_site_warranty_quota_and_cooldown in server.py to use the idiomatic frappe.db.get_single_value API instead of frappe.get_value(…, None, …) for reading Single DocType fields.

• press/press/doctype/server/server.py: Replaces two frappe.get_value(\"Press Settings\", None, field) calls with frappe.db.get_single_value(\"Press Settings\", field) — the correct and explicit API for Single doctypes; semantically equivalent but more readable.
• 47 test files: Adds comprehensive unit and integration tests covering RBAC guards, validation helpers, deploy-candidate utilities, warranty-quota logic, cluster topology, and webhook URL validation, using in-memory fixtures and unittest.mock where appropriate.
• .gitignore: Adds session.md, frappe_cloud_tests_specs.md, and press/run_tests_local.py to the ignore list.

Confidence Score: 5/5

Safe to merge — the single production change is a straightforward API idiom improvement with no behaviour difference, and the test additions are additive only.

The production change in server.py swaps frappe.get_value with frappe.db.get_single_value for a Single DocType, which are semantically identical. No logic is altered. All other changes are pure test additions with no impact on runtime behaviour.

test_server.py contains a duplicate test and a misleading assertion; no files require blocking attention.

Important Files Changed

Filename	Overview
press/press/doctype/server/server.py	Replaces frappe.get_value(…, None, field) with frappe.db.get_single_value for Press Settings Single DocType — correct and idiomatic change with no behaviour difference.
press/press/doctype/server/test_server.py	Adds TestSetDedicatedServerWarrantyQuota and TestGetTeamsWithUnpaidInvoicesOverThreshold; the latter contains two duplicate test methods that both only assert isinstance(result, set), where the first claims to verify 'no teams' but never asserts the result is empty.
press/press/doctype/team/test_team.py	Large expansion: 13 new test classes covering RBAC guards, team-member permission guards, Press Role lifecycle, create_user_resource idempotency, and team utility functions. Well-structured with proper setUp/tearDown and DB rollback.
press/press/doctype/site/test_site_plan_utils.py	New file with 5 test classes covering warranty quota helpers, attachment logic, and plan-level warranty flag; all use DB rollback and targeted mocking correctly.
press/press/doctype/deploy_candidate/test_deploy_candidate_utils.py	New file exercising pure-utility functions with tempfile fixtures and targeted mocking; logic is sound.
press/press/doctype/cluster/test_cluster.py	Adds validation helpers (CIDR, flush-table hour, monitoring password) and firewall normalisation tests using in-memory Cluster docs.
press/press/doctype/virtual_machine/test_virtual_machine.py	Adds data-disk snapshot and volume-helper tests; client patched to MagicMock to avoid real API calls.
press/press/doctype/release_group/test_release_group.py	Adds TestCanUseRelease and TestReleaseGroupDeployBlocking; tests correctly mirror the public/private and status-based logic in can_use_release.
press/press/doctype/app_source/test_app_source.py	Adds tearDown rollback and new tests for validate_source_signature, validate_duplicate_versions, set_required_apps, and get_repo_url including private-repo token paths.
press/press/doctype/team_member_resource/test_team_member_resource.py	Adds comprehensive validation tests for TeamMemberResource using typed fixtures and create_test_user.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR: Improve Test Coverage] --> B[server.py change]
    A --> C[47 Test Files]
    B --> B1["frappe.get_value -> frappe.db.get_single_value"]
    C --> C1[Team RBAC Tests - 13 classes]
    C --> C2[Server / Warranty Tests]
    C --> C3[Cluster Topology Tests]
    C --> C4[Virtual Machine Tests]
    C --> C5[Deploy Candidate Utils]
    C --> C6[Site Plan Utils]
    C --> C7[Release Group Gate]
    C --> C8[App Source Tests]
    C --> C9[Team Member Resource]

Loading

_{Reviews (10): Last reviewed commit: "fix(tests): address remaining review obs..." | Re-trigger Greptile}

[codecov]

Codecov Report

❌ Patch coverage is 98.60048% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.40%. Comparing base (5524957) to head (d251c84).
⚠️ Report is 115 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ress_role_permission/test_press_role_permission.py	60.93%	25 Missing ⚠️
..._method_permission/test_press_method_permission.py	76.36%	13 Missing ⚠️
...ss/press/doctype/agent_update/test_agent_update.py	95.29%	8 Missing ⚠️
...ress/press/doctype/app_release/test_app_release.py	98.30%	2 Missing ⚠️
...pe/deploy_candidate/test_deploy_candidate_utils.py	98.82%	2 Missing ⚠️
press/press/doctype/team/test_team.py	99.67%	2 Missing ⚠️
press/press/doctype/cluster/test_cluster.py	99.60%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #6516      +/-   ##
===========================================
+ Coverage    50.13%   53.40%   +3.26%     
===========================================
  Files          956      959       +3     
  Lines        79329    83039    +3710     
  Branches       375      375              
===========================================
+ Hits         39775    44345    +4570     
+ Misses       39526    38666     -860     
  Partials        28       28              

Flag	Coverage Δ
dashboard	61.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[greptile-apps]

Want your agent to iterate on Greptile's feedback? Try greploops.