[illuusio]

Add BSD-2-Clause identifiers to atf-c to C-source and header files. This does not comply FreeBSD style(9) guidance.

[ngie-eign]

This change actually breaks the BSD-2-Clause text.

Please put the SPDX ID on its own line outside the body of the licensing text, e.g.,

/* Copyright (c)...
 * All rights reserved.
 * ...
 * IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.   */
/** SPDX-License-Identifier: BSD-2-Clause **/

I could make a similar change, but if you're interested in doing this (for licensing mining reasons), I'm more than happy to have you lead this effort.

[emaste]

This change actually breaks the BSD-2-Clause text.

How so? SPDX tags merely need to be in a comment near the top of the file.

[illuusio]

Yes I can make needed changes but I have bit similar view than @emaste that SDPX-License-indentifier should be as top as possible.

[ngie-eign]

The original issue was also more the fact that the licensing text itself had been broken up from the required BSD license boilerplate.
For example:

/**
 * Copyright (c)...
 * SPDX-License-Identifier: BSD-2-Clause
 * All rights reserved.
 *
 * ...
 */

Doing what's shown above can confuse naïve license parsers (which don't expect that text there), can confuse humans (one line in a large block of text is harder to notice; people could copy-paste the bad template), and reduces the overall benefit of the SPDX license ID lines.
My recommendation to move the SPDX license ID outside the license block was to highlight its presence. Whether it's at the top or lower down in the file is less relevant than the other points I highlighted above.

[illuusio]

Doing what's shown above can confuse naïve license parsers (which don't expect that text there), can confuse humans (one line in a large block of text is harder to notice; people could copy-paste the bad template), and reduces the overall benefit of the SPDX license ID lines.
My recommendation to move the SPDX license ID outside the license block was to highlight its presence. Whether it's at the top or lower down in the file is less relevant than the other points I highlighted above.

I'm ok with this reasoning as said current BSD SDPX documentation is simply hazard to parsers. What do you thing @emaste?

[emaste]

/* SPDX... */ is fine with me

[ngie-eign]

same as long as the existing copyright tort is left in place.

[ngie-eign]

@illuusio : I put the SPDX comments below the copyright tort to diff reduce with :master. Please let me know if you are ok with squashing/merging the changes.

[illuusio]

Sorry being bit lazy with this and many thanks that you made update. It been on my list ages. LGTM and squash is ok to me.