Repository navigation
Add -v flag to atf-check - #205
Merged
Merged
Conversation
ngie-eign
reviewed
Nov 3, 2026
ngie-eign
left a comment
ngie-eign
left a comment
Contributor
There was a problem hiding this comment.
Was this contribution assisted by coding agents? If so, could that please be documented in the commit?
Thank you!
holmuk
force-pushed
the
atf-check-issue-104
branch
2 times, most recently
from
November 5, 2026 14:19
7ec8f5f to
b4d9c6a
Compare
ngie-eign
approved these changes
Nov 5, 2026
The -v flag of atf-check can be used to display captured stdout and stderr even when all checks succeed. This commit also document the flag and add tests for successful checks, failures, and retries. Signed-off-by: Pavel Grakhov <altogetherx@gmail.com> Assisted-by: Codex (GPT-6 Luna) Closes freebsd#104
holmuk
force-pushed
the
atf-check-issue-104
branch
from
November 6, 2026 07:07
b4d9c6a to
6c458d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
-vflag toatf-checkto display captured stdout/stderr even when all checks succeed. When combined with-r, it displays output from each attempt.A short option was chosen to match the existing cmd interface (
-s,-o, etc.). Adding a long option (--verbose) would require introducing long-option parsing, so I decided not to do so even though the issue title suggested use of a long option.Several test cases were added for the new flag.
Also, the
atf-check(1)manual now documents-v.Resolves #104
GPT 6-Astra was used to research the existing code, to adjust the man page, and also to suggest how to write tests