Skip to content

Fix update propagation by increasing TTL in ping tests #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 49 commits into
base: main
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Fix Update Propagation in Ping Tests

This PR fixes the update propagation issues in the ping tests by increasing the TTL (Time-To-Live) for ping entries from 30 seconds to 120 seconds in both tests:

  • run_app_blocked_peers_retry.rs: Increased TTL from 30s to 120s
  • run_app_improved_forwarding.rs: Increased TTL from 5s to 120s

Problem

The tests were failing with "Not all tags propagated to all nodes even with retry mechanism!" because the TTL was shorter than the wait time for the retry mechanism to complete. This caused entries to expire before they could be propagated to all nodes.

Solution

By increasing the TTL to 120 seconds, entries remain valid throughout the test, allowing the retry mechanism to successfully propagate updates to all nodes.

Testing

  • run_app_blocked_peers_retry test now passes
  • run_app_improved_forwarding test now passes

Link to Devin run: https://app.devin.ai/sessions/55894ebeb8ab411e87e331df66aed18a
Requested by: Ian Clarke ([email protected])

iduartgomez and others added 21 commits May 11, 2025 08:36
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link
Collaborator

@iduartgomez iduartgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good change, it was aggresive dropping a connection if it was failing to broadcast in time, although in theory it should! We need to look after why we need retries or such long time outs but we can do that in a different PR and it may be related to transport issues.

@iduartgomez
Copy link
Collaborator

iduartgomez commented May 13, 2025

The “blocked peers” tests need to replicate the logic of the test checking eventual consistency in run_app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant