-
-
Notifications
You must be signed in to change notification settings - Fork 90
Fix update propagation by increasing TTL in ping tests #1596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix update propagation by increasing TTL in ping tests #1596
Conversation
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
… direct send Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
…riesReached Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
…routing Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
…ed peers Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
…1747151235-fix-update-propagation
Co-Authored-By: Ian Clarke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good change, it was aggresive dropping a connection if it was failing to broadcast in time, although in theory it should! We need to look after why we need retries or such long time outs but we can do that in a different PR and it may be related to transport issues.
…erge Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
The “blocked peers” tests need to replicate the logic of the test checking eventual consistency in run_app |
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
Co-Authored-By: Ian Clarke <[email protected]>
…e updates Co-Authored-By: Ian Clarke <[email protected]>
Fix Update Propagation in Ping Tests
This PR fixes the update propagation issues in the ping tests by increasing the TTL (Time-To-Live) for ping entries from 30 seconds to 120 seconds in both tests:
run_app_blocked_peers_retry.rs
: Increased TTL from 30s to 120srun_app_improved_forwarding.rs
: Increased TTL from 5s to 120sProblem
The tests were failing with "Not all tags propagated to all nodes even with retry mechanism!" because the TTL was shorter than the wait time for the retry mechanism to complete. This caused entries to expire before they could be propagated to all nodes.
Solution
By increasing the TTL to 120 seconds, entries remain valid throughout the test, allowing the retry mechanism to successfully propagate updates to all nodes.
Testing
run_app_blocked_peers_retry
test now passesrun_app_improved_forwarding
test now passesLink to Devin run: https://app.devin.ai/sessions/55894ebeb8ab411e87e331df66aed18a
Requested by: Ian Clarke ([email protected])