fix: restore mesh assertion to 2 P2P connections minimum#107
Merged
Conversation
Reverts the weakening from PR #105 which lowered min_p2p_per_peer from 2 to 1 and max_wait from 90s to 60s. The underlying issue (slow topology formation) is fixed in freenet-core PR #3039 which accelerates the topology maintenance loop for peers below min_connections. Closes #106 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…name freenet-core renamed serve_gateway to serve_client_api upstream. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
min_p2p_per_peer=2(was 1) andmax_wait=90s(was 60s)serve_gateway→serve_client_apito match freenet-core API renameContext
PR #105 lowered the mesh assertion bar because peers couldn't form enough P2P connections within the timeout. This masked the real problem: freenet-core's topology maintenance loop had a 60-second tick rate and BTreeSet deduplication that limited peers to ~1 connection attempt per minute.
freenet/freenet-core#3039 fixes the root cause by:
With the freenet-core fix, peers reach 2+ P2P connections well within 90 seconds.
Test plan
Closes #106
[AI-assisted - Claude]