Enable more rules for SelfCheck

build.fsx

@@ -12,6 +12,7 @@ open Fake.IO.FileSystemOperators
 open Fake.IO.Globbing.Operators
 open Fake.Core.TargetOperators
 open Fake.Api
+open Newtonsoft.Json.Linq
 
 open System
 open System.IO
@@ -209,12 +210,58 @@ Target.create "Push" (fun _ ->
 
 
 Target.create "SelfCheck" (fun _ ->
-    let srcDir = Path.Combine(rootDir.FullName, "src") |> DirectoryInfo
-
-    let consoleProj = Path.Combine(srcDir.FullName, "FSharpLint.Console", "FSharpLint.Console.fsproj") |> FileInfo
-    let sol = Path.Combine(rootDir.FullName, "FSharpLint.sln") |> FileInfo
-    exec "dotnet" (sprintf "run lint %s" sol.FullName) consoleProj.Directory.FullName
-)
+    let runLinter () =
+        let srcDir = Path.Combine(rootDir.FullName, "src") |> DirectoryInfo
+
+        let consoleProj =
+            Path.Combine(srcDir.FullName, "FSharpLint.Console", "FSharpLint.Console.fsproj")
+            |> FileInfo
+
+        let sol = Path.Combine(rootDir.FullName, "FSharpLint.sln") |> FileInfo
+        exec "dotnet" (sprintf "run lint %s" sol.FullName) consoleProj.Directory.FullName
+
+    printfn "Running self-check with default rules..."
+    runLinter ()
+
+    let fsharplintJsonDir = Path.Combine("src", "FSharpLint.Core", "fsharplint.json")
+    let fsharplintJsonText = File.ReadAllText fsharplintJsonDir
+
+    let excludedRules =
+        [
+            "typedItemSpacing"
+            "typePrefixing"
+            "unionDefinitionIndentation"
+            "moduleDeclSpacing"
+            "classMemberSpacing"
+            "tupleCommaSpacing"
+            "tupleIndentation"
+            "tupleParentheses"
+            "patternMatchClausesOnNewLine"
+            "patternMatchOrClausesOnNewLine"
+            "patternMatchClauseIndentation"
+            "patternMatchExpressionIndentation"
+            // rule is too complex and we can enable it later
+            "cyclomaticComplexity"
+            "unnestedFunctionNames"
+            "nestedFunctionNames"
+            "indentation"
+            "maxCharactersOnLine"
+            "trailingWhitespaceOnLine"
+            "trailingNewLineInFile"
+        ]
+
+    let jsonObj = JObject.Parse fsharplintJsonText
+
+    for pair in jsonObj do
+        let isRule = (jsonObj.SelectToken pair.Key).SelectToken("enabled")
+
+        if not (isNull isRule) && not (List.contains pair.Key excludedRules) then
+            isRule.Replace(JValue true) |> ignore<unit>
+
+    File.WriteAllText(fsharplintJsonDir, jsonObj.ToString())
+
+    printfn "Now re-running self-check with more rules enabled..."
+    runLinter ())
 
 // --------------------------------------------------------------------------------------
 // Build order

paket.dependencies

@@ -7,6 +7,7 @@ nuget Argu
 nuget BenchmarkDotNet
 nuget BenchmarkDotNet.Diagnostics.Windows
 nuget FParsec
+nuget FSharpx.Collections
 nuget FSharp.Compiler.Service ~> 41.0.1
 nuget Ionide.ProjInfo.ProjectSystem == 0.61.3
 nuget Ionide.ProjInfo.FCS == 0.61.3
@@ -60,4 +61,4 @@ group Build
   nuget Fake.Core.UserInput
   nuget Fake.IO.FileSystem
   nuget Fake.DotNet.MsBuild
-  nuget Fake.Api.GitHub
+  nuget Fake.Api.GitHub

paket.lock

@@ -59,6 +59,8 @@ NUGET
       FSharp.Core (>= 4.7.2)
       System.Reactive (>= 5.0 < 6.0)
     FSharp.Core (6.0.7)
+    FSharpx.Collections (3.1)
+      FSharp.Core (>= 4.3.4)
     Gee.External.Capstone (2.3)
     Iced (1.20)
     Ionide.ProjInfo (0.61.3)

src/FSharpLint.Console/Output.fs

@@ -23,8 +23,8 @@ type StandardOutput () =
             if String.length errorLine = 0 then "^"
             else
                 errorLine
-                |> Seq.mapi (fun i _ -> if i = range.StartColumn then "^" else " ")
-                |> Seq.reduce (+)
+                |> Seq.mapi (fun index _ -> if index = range.StartColumn then "^" else " ")
+                |> Seq.fold (+) String.Empty
         getErrorMessage range + Environment.NewLine + errorLine + Environment.NewLine + highlightColumnLine
 
     let writeLine (str:string) (color:ConsoleColor) (writer:IO.TextWriter) =

src/FSharpLint.Console/Program.fs

@@ -86,8 +86,10 @@ let private start (arguments:ParseResults<ToolArgs>) (toolsPath:Ionide.ProjInfo.
     if arguments.Contains ToolArgs.Version then
         let version = 
             Assembly.GetExecutingAssembly().GetCustomAttributes false
-            |> Seq.pick (function | :? AssemblyInformationalVersionAttribute as aiva -> Some aiva.InformationalVersion | _ -> None)
-        sprintf "Current version: %s" version |> output.WriteInfo
+            |> Seq.tryPick (function | :? AssemblyInformationalVersionAttribute as aiva -> Some aiva.InformationalVersion | _ -> None)
+        match version with
+        | Some ver -> sprintf "Current version: %s" ver |> output.WriteInfo
+        | None -> output.WriteInfo "No version information found in assembly attributes."
         ()
 
     let handleError (str:string) =
@@ -132,9 +134,9 @@ let private start (arguments:ParseResults<ToolArgs>) (toolsPath:Ionide.ProjInfo.
                 | _ -> Lint.lintProject lintParams target toolsPath
             handleLintResult lintResult
         with
-        | e ->
+        | exn ->
             let target = if fileType = FileType.Source then "source" else target
-            sprintf "Lint failed while analysing %s.\nFailed with: %s\nStack trace: %s" target e.Message e.StackTrace
+            sprintf "Lint failed while analysing %s.\nFailed with: %s\nStack trace: %s" target exn.Message exn.StackTrace
             |> handleError
     | _ -> ()