RequireQualifiedAccess section#39
Merged
bartelink merged 6 commits intofsprojects:masterfrom Mar 23, 2026
Merged
Conversation
bartelink
reviewed
Mar 18, 2025
| statements to avoid pitfalls; `AutoOpen` would sidestep this. | ||
| #### Use `AutoOpen` and/or ignore `RequireQualifiedAccess` best practice with caution! | ||
|
|
||
| Functions with identical names from different modules will silently "shadow" each other, causing the most recently imported definition to be used instead of the one you might expect. **The compiler will _not_ warn you that this has happened.** Even if your code works, you may encounter compiler errors if the `open` order changes. A [coding convention (MS Learn)](https://learn.microsoft.com/en-us/dotnet/fsharp/style-guide/conventions#sort-open-statements-topologically) exists for `open` statements to avoid pitfalls. |
Member
There was a problem hiding this comment.
this warning about silent meaning changes is not inaccurate, but I can imagine it scaring people into thinking they might as well be using something typeless. I dont know how I'd convey it, but the only real problem it triggers is inferring the wrong type where it's not pinned, which then manifests as an error some distance away in terms of files or compile time.
bartelink
approved these changes
Mar 18, 2025
Member
bartelink
left a comment
bartelink
left a comment
There was a problem hiding this comment.
In general I like this - just added a pondering comment
bartelink
reviewed
Apr 16, 2025
Member
|
Thanks @IanWitham for a very useful contribution; apologies for the long delay before merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added section for RequireQualifiedAccess, plus slight editing of the preceding "AutoOpen" paragraph, per #31