Skip to content

Subject APIを追加#11

Merged
hikaru-0602 merged 83 commits intomainfrom
feature/subject-api
Feb 20, 2026
Merged

Subject APIを追加#11
hikaru-0602 merged 83 commits intomainfrom
feature/subject-api

Conversation

@hikaru-0602
Copy link
Contributor

@hikaru-0602 hikaru-0602 commented Feb 16, 2026 •
edited
Loading

やったこと

  • ドメインモデル定義
  • 環境変数にdevのSubjectAPIのurl追加
  • 複数のAPIクライアント生成の処理をまとめた
  • それに伴うmain.goでの初期化処理を修正
  • facultyのHandler，Service，Repository実装
  • 各APIのテストのために，Handlerの初期化をWithパターンに変更，それに伴いAnnouncementTestの修正
  • ConverterにFacultyの変換関数を追加
  • 同様にCourse実装
  • 同様にTimetable実装
  • Subject_Category実装
  • Subject実装
  • モックを実装
  • テストを実装
  • converterをどうするか考える．ディレクトリで分けるか，各Handlerファイルにそれぞれ変換関数を追加するか
  • モックのデフォルト値を削除
  • 各テストケースでsetupMockを設定
  • ドメインモデルからJson削除
  • ドメインモデルにカスタムIDを設定
  • ドメイン，external，サービス，リポジトリ削除
  • Handlerに直接クライアント渡す
  • クライアントの注入チェック追加
  • エラー時のレスポンス修正

@hikaru-0602 hikaru-0602 self-assigned this Feb 16, 2026
@hikaru-0602 hikaru-0602 changed the title Feature/subject api Subject APIを追加 Feb 16, 2026
Copilot AI review requested due to automatic review settings February 19, 2026 01:40
Copilot AI reviewed Feb 19, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 50 out of 50 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kantacky kantacky mentioned this pull request Feb 19, 2026
Closed
kantacky
kantacky approved these changes Feb 20, 2026
View reviewed changes
Copy link
Member

@kantacky kantacky left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev環境にデプロイしてぽちぽちしましたが、動いていそうなのでOK
descriptionだけ書き換えてもらえると

Copilot AI review requested due to automatic review settings February 20, 2026 07:58
Copilot AI reviewed Feb 20, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hikaru-0602
Update internal/handler/day_of_week_timetable_slot.go
99bb390 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 20, 2026 08:05
@hikaru-0602
Update internal/handler/subject.go
3962411 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
hikaru-0602 and others added 4 commits February 20, 2026 17:05
@hikaru-0602
Update internal/handler/subject_category.go
d8c5e25 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@hikaru-0602
Update internal/handler/announcement.go
76fae46 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@hikaru-0602
Update internal/handler/faculty.go
be1a29b 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@hikaru-0602
Update internal/handler/course.go
cb28ff3 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI reviewed Feb 20, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hikaru-0602
Update internal/handler/subject.go
c885262 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 20, 2026 08:10
Copilot AI reviewed Feb 20, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

go.mod
Comment on lines 5 to 13
require (
firebase.google.com/go/v4 v4.19.0
github.com/getkin/kin-openapi v0.133.0
github.com/gin-gonic/gin v1.11.0
github.com/joho/godotenv v1.5.1
github.com/oapi-codegen/gin-middleware v1.0.2
github.com/oapi-codegen/runtime v1.1.2
github.com/stretchr/testify v1.11.1
google.golang.org/api v0.231.0
)
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR説明では「テストを実装」とありますが、この変更で *_test.go がリポジトリから無くなっており（go.mod からも testify が削除されています）、現状だと自動テストが一切実行できません。テストを追加し直すか、意図的に削除したのであればPR説明（チェックボックス）を更新して整合させてください。

Copilot uses AI. Check for mistakes.
masaya-osuga
masaya-osuga approved these changes Feb 20, 2026
View reviewed changes
Copy link
Member

@masaya-osuga masaya-osuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hikaru-0602 hikaru-0602 merged commit 1171bfc into main Feb 20, 2026
5 checks passed
@hikaru-0602 hikaru-0602 deleted the feature/subject-api branch February 20, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@kantacky kantacky kantacky approved these changes

@masaya-osuga masaya-osuga masaya-osuga approved these changes

Assignees

@hikaru-0602 hikaru-0602

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hikaru-0602 @kantacky @masaya-osuga