Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 257 257
=========================================
Hits 257 257 ☔ View full report in Codecov by Sentry. |
Bisaloo
left a comment
There was a problem hiding this comment.
Thanks, it's looking good. Should we provide a renv.lock lockfile alongside it to ensure easier reproducibility?
I'm on the fence because we want to take into account updates to the packages we're comparing fundiversity to. But I'm afraid that updates to, e.g., rlang may be slightly annoying to diagnose and take into account if we want to re-run this script.
On the other hand, having renv.lock doesn't mean we have to use it. It can also serve as a session info to help in diagnosing what is preventing reproducibility.
Add the benchmark scripts used for the manuscript in
inst/folder in order to keep in the main repo instead of merging the full manuscript as suggested in #72