Closed
Conversation
xFrednet
reviewed
May 6, 2025
Collaborator
xFrednet
left a comment
xFrednet
left a comment
There was a problem hiding this comment.
Decent overall, please also check the CI
| }); | ||
| } | ||
|
|
||
| void assert_rc__function_impl( |
Collaborator
There was a problem hiding this comment.
Suggested change
| void assert_rc__function_impl( | |
| void assert_rc_function_impl( |
| } | ||
| // Remove string object whitespace | ||
| auto s = count_str->get_name(); | ||
| if (s[0] == '\"') |
Collaborator
There was a problem hiding this comment.
This can be undefined behaviour, if the string is empty
|
|
||
| void test_builtins() | ||
| { | ||
| // Onus is on caller to provide a string object representing an actual integer |
| expected = "2" | ||
| assert_lrc(r1, expected) | ||
| # Using string directly | ||
| assert_lrc(r1, "2") No newline at end of file |
Collaborator
There was a problem hiding this comment.
Suggested change
| assert_lrc(r1, "2") | |
| assert_lrc(r1, "2") | |
Some in the other files
| @@ -0,0 +1,3 @@ | |||
| # Not a string | |||
| a = {} | |||
| assert_lrc(a, a) No newline at end of file | |||
Collaborator
There was a problem hiding this comment.
The first argument should be a bridge
| auto count_str = frame->stack_pop("count_str"); | ||
| auto bridge = frame->stack_pop("bridge"); | ||
| // Make sure we're comparing the correct LRC value | ||
| rt::remove_reference(frame->object(), bridge); |
Collaborator
There was a problem hiding this comment.
This can cause undefined behaviour of the RC hits 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builtin functions to assert lrc/sbrc