-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Various improvements to calendar widget #5811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…with SelectedDate) - added localized month name - added a function to programmatically change the currently displayed date - added the ability to select a date, and a function to programmatically change the selected date - fixed crash when OnChanged callback in not set - calendar of DateEntry will now open with currently entered date selected - corrected Calendar popup positioning (do not resize the popup, keep it always at its minSize)
- SetDisplayedDate => SetDisplayedMonth - Removed commented code - Removed Resize handler in DateEntry (not needed)
Thanks for this. Though, I would like to point out that PRs that introduce new bigger features are usually easier to review and land if they focus on one at a time. Fixes and smaller changes can often be grouped together though. Not something you need to change now but it is worth keeping in mind m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review. I added some minor comments inline. It would also be good to add some tests for this. Also, please do tick the boxes in the PR template as appropriately.
Ok done for the inline comments. |
Description:
Some enhancements to Calendar widget and DateEntry
What to discuss next:
Another one I just want to understand:
Checklist: