Update widgets to use theme.XYZForWidget helpers #5895
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andydotxyz
reviewed
Aug 11, 2025
There was a problem hiding this comment.
Thanks, it is a nice cleanup.
However on the methods that look up many items in a row there will now be additional hits to the theme cache.
That is obviously fixed by your other PR to cache the current widget in those calls, so should this PR be held back until that lands?
| assert.False(t, check.Disabled()) | ||
| } | ||
|
|
||
| func TestCheckRenderer_ApplyTheme(t *testing.T) { |
There was a problem hiding this comment.
Rather than removed shouldn't this be updated to test the alternative theme like we have done in other widgets (the "ugly" variant)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #5894
I may not have gotten 100% of them but it doesn't entirely matter -- the point is for the widgets code to be a demonstration of the current, recommended way to write custom widgets, using the latest theme helper APIs introduced in 2.5.
Checklist:
Where applicable: