Redesign group-by aggregation API#79
Draft
gene-bordegaray wants to merge 3 commits into
Draft
Conversation
gene-bordegaray
changed the title
gene-bordegaray
force-pushed
the
gene.bordegaray/2026/07/groupby-api-redesign
branch
from
0a549e5 to
df15a00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CuDFGroupByaggregation API aroundGroupByRequest,Aggregation, andCuDFGroupByResult.Stack
This PR is stacked on #78 (
gene.bordegaray/2026/06/join-api-redesign).Root Cause
The previous group-by wrapper exposed a less composable request API and returned raw nested tuples. While adding NUNIQUE and MEDIAN coverage, cleanup crashes exposed a wrapper lifetime issue: cuDF groupby/view handles could be dropped after the Rust-owned key/view storage or producer stream readiness they depended on.
Validation
cargo test --workspace