- 
                Notifications
    
You must be signed in to change notification settings  - Fork 164
 
Refresh and de-duplicate install instructions for users and developers #566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| 
           @rahulsavani @tturocy Is the GUI installable on Windows/Linux or only Mac?  | 
    
| 
           There are .msi installers for Windows built with every release.  | 
    
          
 Thanks Ted, I have changed it to link to the releases page where the installers can be found. I left the mac manual build instructions in since unfortunately my Turing Mac couldn't trust the dmg downloaded from the release page wasn't malware - so I guess others might find this too  | 
    
| 
           Apple makes it deliberately misleading as to how to install/run unsigned apps. Meanwhile they charge an extortionate amount to sign them (at least from the perspective of an open-source developer). Does Turing have some dev account that can be used to sign these? Building on Windows is at best going to be complicated, because at present it is going to require having e.g. MinGW installed so as to use the autotools setup, followed by having to have wxWidgets installed correctly as well. While it would be good to document this, equally in truth the documentation for "building Gambit on Windows" would consist of "(1) Throw out your computer and get one that runs MacOS or Linux; (2) See those build directions" It would be easier! :)  | 
    
| 
           I'm unsure about a few things here in this approach - we definitely need to improve our documentation on this but I'm not sure this is the best way to do it. First - we already have build directions in  Putting instructions to build the GUI in what's effectively the GUI user's guide isn't the best place. GUI users in the first instance should be pointed rather firmly to using pre-built versions. The audience for the GUI is primarily those who don't have a lot of coding experience - so putting build instructions in for them isn't going to help! Aside from our provided .dmg (which yes needs better instructions for working around the misleading OSX errors), it's also available via homebrew, and that seems like where we should be pointing them. We should though move this text into the "developer" build section and update accordingly. Even there, it would also seem like a good idea in the first instance to be pointing users to build Gambit against the homebrew wxWidgets, rather than downloading and building wxWidgets directly. The only reason we download wxWidgets directly in our GitHub action is that the homebrew wxWidgets builds shared libraries - our GitHub action is designed for static linkage so our resulting binary doesn't have any dependencies (including wxWidgets).  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments in main conversation thread on placement of this and build strategy.
          
 Thanks @tturocy I made the following changes: 
  | 
    
| 
           This might be scope creep - but looking at the build instructions file, it seems like it might be better for us to look at that whole section holistically? The thought is that the section is really imbalanced, with very detailed instructions badged as "building the GUI on MacOS". But actually most of those instructions apply to building the command-line tools as well; they're really not GUI specific. Further, they aren't really Mac-specific either - at least all of the bits about autotools and the like apply across all platforms. The detail in the new build instructions is a big improvement - I'm thinking that while we are looking at the section we should simply go through and as best we can try to improve/refresh the whole section along those lines, for all platforms.  | 
    
| 
           And to pile on, I also realised we have an   | 
    
          
 Thanks @tturocy I think let's discuss and plan today or in another one of our weekly sessions exactly how this should look  | 
    
          Update from meeting 28th October
  | 
    
| 
           @tturocy @rahulsavani I've had a good go at updating the installation pages today. Let me know your thoughts, here are the key pages with changes: 
 The main thing that's lacking are the Windows sections as we discussed, but I think if anything the way I've presented it especially in the dev docs gets across that we haven't tested these recently. We can update these parts in a subsequent pull request.  | 
    
Closes #577