-
Notifications
You must be signed in to change notification settings - Fork 165
Remove "dominated actions" method #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Along the way, this also makes a minor improvement by correctly showing the dominance toolbar if dominance is checked while viewing the extensive game, and then the user moves to the strategic game.
This was implementing "conditional agent dominance", which is at best a confusing and not-very-standard concept. And if we do decide to implement it in future there will be better ways of doing so.
# Conflicts: # src/games/behavspt.h
# Conflicts: # src/games/layout.cc # src/games/layout.h # src/gui/efglayout.cc # src/gui/efglayout.h
rahulsavani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal of the Dominance toolbar for an extensive game seems to have been done fine, though investigating this did lead to issue #648.
I do note that now when we have an extensive game and click on Dominance under the Tools menu item, nothing happens, which is not ideal, but since this does cause something to happen when viewing the reduced strategic form of an extensive game, and we probably can't make this context specific, we probably just need to have it always appear in the Tools menu.
|
The issue of the menu did occur to me. What would you suggest for the behaviour? It should be disabled menu item when viewing the tree? Should it retain its checkbox though? What I mean is: suppose you pass to strategic form, show the dominance toolbar, then go back to extensive. Would |
edwardchalstrey1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I built the GUI from this branch, loaded an EFG and tried Tools -> Dominance and nothing happens, so I agree with Rahul's comments.
@tturocy There is a checkbox in the top comment about updating docs, however I don't see any docs changes in this PR?
So then:
I think it should retain the check box, but it can't be changed from the extensive view.
Yes. |
See #612.
Done so far:
Still to do: