Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Disable binary upload #511

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

petersutter
Copy link
Member

@petersutter petersutter commented Jan 21, 2025

What this PR does / why we need it:
We should transition to reusing the binaries generated by the CI pipeline instead of building them separately in the Action (or vice versa, as described in #509). Currently, we have disabled the binary upload from the CI pipeline, but this should be re-enabled once we implement the proper reuse strategy.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
gardener/cc-utils#1120

Release note:

We should transition to reusing the binaries generated by the CI pipeline instead of building them separately in the Action. Currently, we have disabled the binary upload from the CI pipeline, but this should be re-enabled once we implement the proper reuse strategy.
@petersutter petersutter requested a review from a team as a code owner January 21, 2025 11:34
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 21, 2025
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jan 21, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 21, 2025
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Feb 4, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 4, 2025
@petersutter petersutter merged commit 5f2cd06 into master Feb 4, 2025
9 checks passed
@petersutter petersutter deleted the disable-ci-binary-upload branch February 4, 2025 15:30
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants