Skip to content

fix: getOperationEvents use create EmptySchema not javascript empty object #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2025
Merged

fix: getOperationEvents use create EmptySchema not javascript empty object #951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion webui/src/state/oplog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import {
} from "../../gen/ts/v1/operations_pb";
import { GetOperationsRequest, OpSelector } from "../../gen/ts/v1/service_pb";
import { BackupProgressEntry, ResticSnapshot, RestoreProgressEntry } from "../../gen/ts/v1/restic_pb";
import { EmptySchema } from "../../gen/ts/types/value_pb";
import { create } from "@bufbuild/protobuf";
import _ from "lodash";
import { backrestService } from "../api";

Expand All @@ -16,7 +18,7 @@ const subscribers: ((event?: OperationEvent, err?: Error) => void)[] = [];
while (true) {
let nextConnWaitUntil = new Date().getTime() + 5000;
try {
for await (const event of backrestService.getOperationEvents({})) {
for await (const event of backrestService.getOperationEvents(create(EmptySchema, {}))) {
console.log("operation event", event);
subscribers.forEach((subscriber) => subscriber(event, undefined));
}
Expand Down
4 changes: 3 additions & 1 deletion webui/src/views/SummaryDashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ import {
SummaryDashboardResponse,
SummaryDashboardResponse_Summary,
} from "../../gen/ts/v1/service_pb";
import { EmptySchema } from "../../gen/ts/types/value_pb";
import { create } from "@bufbuild/protobuf";
import { backrestService } from "../api";
import { useAlertApi } from "../components/Alerts";
import {
Expand Down Expand Up @@ -65,7 +67,7 @@ export const SummaryDashboard = () => {
}

try {
const data = await backrestService.getSummaryDashboard({});
const data = await backrestService.getSummaryDashboard(create(EmptySchema, {}));
setSummaryData(data);
} catch (e) {
alertApi.error("Failed to fetch summary data: " + e);
Expand Down