Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Elastic Mode #359 #401

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Conversation

snowAvocado
Copy link
Contributor

Ticket(s)

Description

Related PRs

Development Checklist

  • I have added a descriptive title to this PR.
  • I have squashed related commits together.
  • I have rebased my branch on top of the latest main branch.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added docstring(s) to my code.
  • I have made corresponding changes to the documentation (docs).
  • I have added tests for my changes.
  • I have signed all the commits.

Legal Checklist

@snowAvocado snowAvocado marked this pull request as draft December 30, 2023 09:01
@snowAvocado snowAvocado marked this pull request as ready for review December 30, 2023 12:24
@snowAvocado
Copy link
Contributor Author

#359

Copy link
Member

@mostafa mostafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @snowAvocado,

Thanks for your contribution! 🙌 Please regenerate protobuf stubs by running make gen. I can do it as well if you want.

@mostafa mostafa linked an issue Dec 30, 2023 that may be closed by this pull request
@snowAvocado
Copy link
Contributor Author

@mostafa, Thanks for your comments. I pushed new commit with protobuf changes

regenerate protobuf for api.proto change
Copy link
Member

@mostafa mostafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@snowAvocado
Would you mind updating the docs as well?

@mostafa mostafa merged commit 09366a4 into gatewayd-io:main Dec 31, 2023
3 checks passed
@snowAvocado
Copy link
Contributor Author

@mostafa I opened new pull request for documentation changes in docs repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove elastic mode
2 participants