5688 paralise st #5762
5688 paralise st #5762
Conversation
|
|
||
| @SystemTestSuite | ||
| @ExcludeTags({"slow", "expensive"}) | ||
| @ExcludeTags({"slow1", "slow2", "slow3", "expensive1", "expensive2", "expensive3"}) |
There was a problem hiding this comment.
We could avoid stating all the numbers here if we give the slow and expensive annotations a "slow" and "expensive" tag as well as the numbered tags.
|
|
||
| @SystemTestSuite | ||
| @ExcludeTags("expensive") | ||
| @ExcludeTags({"expensive1", "expensive2", "expensive3"}) |
There was a problem hiding this comment.
We could avoid stating all the numbers here if we give the expensive annotations an "expensive" tag as well as the numbered tags.
| wait | ||
| elif [ "$MAIN_SUITE_NAME" == "functional" ]; then | ||
| echo "Running slow tests in parallel. Start time: [$(time_str)]" | ||
| runSlowTests $@ |
There was a problem hiding this comment.
This $@ needs quoting as in the previous comment #5762 (comment).
scripts/test/nightly/runTests.sh
Outdated
| sudo cp -r scripts quick/scripts | ||
| sudo cp -r python quick/python | ||
| sudo cp -r code-style quick/code-style | ||
| sudo cp -r rust quick/rust |
There was a problem hiding this comment.
Is there a reason to copy the individual folders explicitly like this, rather than copy everything? I could see excluding the Git folder so we don't need to copy the whole Git repository. It might be easier to work with if we either just copy everything, or specifically exclude things rather than include them?
Following up on my previous comment #5762 (comment).
| pushd $SLEEPER_DIR | ||
| #Make copies of the java folder to run independent maven builds in parallel | ||
| sudo rm -rf quick | ||
| mkdir quick |
There was a problem hiding this comment.
Might it be worth putting the copies under a separate folder to make sure there can't be any naming conflicts between the test suites and the real folders?
3 participants
Make sure you have checked all steps below.
Issue
Feature". Note that before an issue is finished, you can still make a pull request by raising a separate issue
for your progress.
Tests
Documentation
separate issue for that below.