Better Err message when $TERM not found #822
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Issue
The
setuptermfunction returns an vague error message ofexit status 1when $TERM variable is set to an invalid value.tcell/terminfo/dynamic/dynamic.go
Lines 119 to 130 in 340fa4f
The error returns 'exit status 1' which is a vague error message to the user
Related Issue & PR
Trying to resolve jesseduffield/lazygit#4868
Related pull Request jesseduffield/lazygit#4881 (comment)