add alias for asc(1) and desc(-1)#130
add alias for asc(1) and desc(-1)#130FvckSh1t wants to merge 1 commit intogeddy:masterfrom FvckSh1t:master
asc(1) and desc(-1)#130Conversation
|
Could you add a test for this? I'll be happy to merge it then. |
|
Hey @mde , but I have only mysql and mongodb installed, and I don't know how to test some specific units, or could you tell me which files to add tests? |
|
You run the tests by doing You'll definitely want to add an integration test. The tests that are shared by all the adapters are here: https://github.com/mde/model/blob/master/test/integration/adapters/shared.js Those tests are not run on their own, but are just used as a mixin for each of the various adapter test modules. So if you add your test in there, and it passes in Mongo and MySQL, you can rely on the Travis CI to ensure that they pass in every other adapter. Looks like we don't have any sort of "sort" tests in the unit tests for query: https://github.com/mde/model/blob/master/test/unit/query/query.js It would be awesome if you can find a way to add a test or two there too. Hope that helps. :) |
|
@mde Thanks, it's pretty kind of you to give such a detailed coach for me! |
|
No worries. Chime in on this thread if you have any questions as you go. Thanks! |
No description provided.