Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new input "end-pipeline-step-before-task-finish" to terminate the pipeline step if the Fargate task has not finished executing. #20

Conversation

jjdmkosmos
Copy link

@jjdmkosmos jjdmkosmos commented Apr 30, 2024

… pipeline step if the Fargate task has not finished executing.

What it solves

Add new input "end-pipeline-step-before-task-finish" to terminate the pipeline step if the Fargate task has not finished executing
...

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • Pull request title is brief and descriptive (for a changelog entry)

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, or enhancement
  • Label as bump:patch, bump:minor, or bump:major if this PR should create a new release

… pipeline step if the Fargate task has not finished executing.
@jjdmkosmos
Copy link
Author

Hi @Ic3w0lf could you check this pr?

@Ic3w0lf
Copy link
Contributor

Ic3w0lf commented May 3, 2024

Hi @jjdmkosmos and thanks for your contribution! Sorry for the late reply, my GitHub notifications are not working properly right now :(

I like the idea but would probably do some small changes on the implementation and naming. I will try to implement your code into the action this weekend.

@Ic3w0lf
Copy link
Contributor

Ic3w0lf commented Jul 5, 2024

Added in #24 via task-wait-until-stopped. Couldn't test everything yet that is why set to pre-release

@Ic3w0lf Ic3w0lf closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants