Bump to latest setup-gel action #1230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the `gel` CLI instead of `edgedb`
elprans
reviewed
Mar 8, 2025
| @@ -63,20 +63,20 @@ jobs: | |||
| yarn format | |||
|
|
|||
| - name: Install Gel | |||
| uses: geldata/setup-gel@6763b6de72782d9c2e5ecc1095986a1c707da68f | |||
| uses: geldata/setup-gel@358410cc5618fa956d16f1b7157a8c86f9b517cf # v1.4 | |||
There was a problem hiding this comment.
This is our trusted action, so just using v1 is fine.
There was a problem hiding this comment.
Well, I mostly mean this to be stable across runs rather than a lack of trust of the upstream. But I'm not sure what we actually get from that, so fair enough!
elprans
approved these changes
Mar 8, 2025
We were accidentally fire-and-forgetting this promise rather than awaiting it and letting it reject the outer promise. Will be introducing more strict linting rules to catch cases like this soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.