Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CentOS/RHEL deployment guide #8425

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Fix CentOS/RHEL deployment guide #8425

merged 1 commit into from
Mar 5, 2025

Conversation

fmoor
Copy link
Member

@fmoor fmoor commented Mar 3, 2025

@fmoor fmoor marked this pull request as ready for review March 3, 2025 18:55
Copy link

github-actions bot commented Mar 3, 2025

Docs preview deploy

✅ Successfully deployed docs preview for commit d73ae52:

https://edgedb-docs-k0bwtgko9-edgedb.vercel.app

(Last updated: Mar 3, 2025, 19:03:26 UTC)

@@ -86,7 +93,7 @@ default. You can start the server by enabling the unit.
$ sudo systemctl enable --now gel-server-6

This will start the server on port 5656, and the data directory will be
``/var/lib/gel/1/data``.
``/var/lib/gel/6/data``.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For versions 6.0 and 6.1 this is a lie. The directory is /var/lib/edgedb/6/data for those versions, but I'm not sure it is worth adding an explanation here. The directory will be correct starting in version 6.2.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to pretend we always intended this and the old behavior was an unintentional defect.

Comment on lines +64 to +70
Disable SELinux.

.. code-block:: bash

$ sed -i 's/SELINUX=enforcing/SELINUX=disabled/' /etc/selinux/config
$ reboot

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will no longer be necessary when geldata/gel-pkg#145 is fixed. If this change is accepted I'll open an issue reminding us to remove this blurb once the gel-pkg issue is fixed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow up issue #8440

@fmoor fmoor requested review from elprans, scotttrinh and beerose March 3, 2025 19:06
Copy link
Contributor

@scotttrinh scotttrinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak to the technical accuracy here, but I don't see any blockers from team-devrel 🙏

@fmoor fmoor merged commit 13ce875 into master Mar 5, 2025
25 checks passed
@fmoor fmoor deleted the fmoor/bare-metal-selinux branch March 5, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants