-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dotnet benchmarks #63
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add running instructions to DEVELOP.rst
.
@elprans can you run the benchmarks on the same machine as the others and commit the results? |
Hm. I'm actually getting an error:
|
That error format looks like it was from an Pulling the movie id it was trying to select and running the query in the CLI throws the same error on my end:
Is this a bug with EdgeDB? |
I've pushed a change to log the ids that are used when an error is thrown |
This seems to be an issue with the data set. There should be at least one review for each movie. |
Is there a quick fix? |
I looked at this again, and the only diff I can see from other benchmarks is that you are not selecting the ids randomly and instead just take the first slice, which somehow contains problematic data. Randomize id selection to see if we can get a successful run. |
Adds both
edgedb_dotnet
andefcore
(most popular .NET ORM) as a benchmark target.Requires .NET 7 SDK to run