-
Notifications
You must be signed in to change notification settings - Fork 0
Add probabilistic model examples and tests for GemPy #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Leguark
wants to merge
10
commits into
clean_repo
Choose a base branch
from
gempy_prob_api
base: clean_repo
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a test script for probabilistic geomodeling using Pyro, incorporating prior sampling, posterior inference, and visualization. This enhances testing coverage with a probabilistic approach while demonstrating Pyro integration with GemPy.
Updated the development log to include a task for investigating the segmentation function, ensuring comprehensive tracking of future tasks.
Refactored probabilistic model setup by modularizing `_prob_run` for clarity and reusability. Added posterior mean value checks, MCMC convergence diagnostics, and cleaned redundant comments to enhance readability and test robustness.
Streamlined probability testing by refining grid logic and posterior checks, added print diagnostics for clarity, and adjusted posterior value assertions. Moved geological layer thickness computation to a separate `_likelihood` function for better modularity and maintainability.
Added "Doing" section highlighting ongoing tasks like code compression and GemPy posterior visualization. This improves clarity on current development efforts.
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DOC] Adding development roadmap and probabilistic modeling enhancements
This PR introduces a comprehensive development roadmap and implements probabilistic modeling capabilities with Pyro integration.
Key Changes:
gempy_probability/modules/model_definition/
The probabilistic workflow now supports sampling from priors, MCMC inference with NUTS, and comprehensive posterior analysis. The implementation includes proper separation of model definition, likelihood computation, and inference procedures.