Let a function return what it computes by value, rather than through a reference argument. #6789
+17
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gassmoeller
approved these changes
Nov 28, 2025
Member
gassmoeller
left a comment
gassmoeller
left a comment
There was a problem hiding this comment.
I agree this is easier to follow. Could you resolve the conflict? Then this is ready to merge.
tjhei
reviewed
Dec 1, 2025
| const double bucket_width, | ||
| Table<dim,unsigned int> &buckets) const; | ||
|
|
||
| */ |
Member
There was a problem hiding this comment.
can you update the doxygen comment for the parameters?
Member
|
ping @bangerth |
…a reference argument.
tjhei
approved these changes
Dec 9, 2025
Contributor
Author
|
Works now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is easier to read.
@JarettBakerDunn FYI.