Skip to content

Add console test #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add console test #501

wants to merge 6 commits into from

Conversation

gjmooney
Copy link
Collaborator

@gjmooney gjmooney commented Feb 26, 2025

Description

Add a UI test for the embedded console.

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--501.org.readthedocs.build/en/501/
💡 JupyterLite preview: https://jupytergis--501.org.readthedocs.build/en/501/lite

Copy link
Contributor

Binder 👈 Launch a Binder on branch gjmooney/jupytergis/console_test

Copy link
Contributor

github-actions bot commented Feb 26, 2025

Integration tests report: appsharing.space

@arjxn-py
Copy link
Member

Bot please update snapshots again :)

@arjxn-py arjxn-py closed this Feb 26, 2025
@arjxn-py arjxn-py reopened this Feb 26, 2025
@arjxn-py
Copy link
Member

Triggering CI after snapshot update

Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good.
Thanks :)

@gjmooney
Copy link
Collaborator Author

please update snapshots

@gjmooney gjmooney closed this Feb 26, 2025
@gjmooney gjmooney reopened this Feb 26, 2025
@martinRenou
Copy link
Member

Mmh. How about juste taking a screenshot of the console, which will be stable 😅

@gjmooney
Copy link
Collaborator Author

Mmh. How about juste taking a screenshot of the console, which will be stable 😅

Making the layer prints the ID of it! Nothing is stable! These screenshots have it out for me!

@arjxn-py
Copy link
Member

Maybe try taking a screenshot without adding the layer?

@martinRenou
Copy link
Member

Making the layer prints the ID of it!

You can fix that by adding a ; at the end of your executed Python code in the console, it will make it stop printing anything

@arjxn-py
Copy link
Member

Bot please update snapshots :)

@arjxn-py arjxn-py closed this Feb 27, 2025
@arjxn-py arjxn-py reopened this Feb 27, 2025
@arjxn-py
Copy link
Member

Triggering CI

@arjxn-py
Copy link
Member

Ahh, this is annoying. The diff:
image

@arjxn-py
Copy link
Member

Although not adding the layer is fine since that's not relevant for this test, but just for future references - this issue was maybe related to the time that jgis takes to load the layer so adding a await page.waitForTimeout(10000); could also help.

@arjxn-py
Copy link
Member

please update snapshots

@gjmooney gjmooney closed this Feb 27, 2025
@gjmooney gjmooney reopened this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants