Skip to content

Dynamic units in buffer dialog #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

mfisher87
Copy link
Member

@mfisher87 mfisher87 commented Mar 19, 2025

Description

This PR includes all changes from #544; rebase after merge. I did this because to show this PR in this repo, I needed to target a branch in this repo, not a branch on Arjun's fork.

Resolves #541

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--554.org.readthedocs.build/en/554/
💡 JupyterLite preview: https://jupytergis--554.org.readthedocs.build/en/554/lite

@mfisher87 mfisher87 added the enhancement New feature or request label Mar 19, 2025
Copy link
Contributor

Binder 👈 Launch a Binder on branch mfisher87/jupytergis/dynamic-units

@mfisher87 mfisher87 marked this pull request as draft March 19, 2025 16:52
@martinRenou
Copy link
Member

@mfisher87 @arjxn-py @kpdavi what would you think of splitting this PR in two?

  • one PR that removes the projection parameter for the buffer processing function (as we discussed during the hackathon, we should probably stay close to the QGIS behavior and not allow to re-project whilst buffering)
  • one PR that investigates having a dynamic unit description. This may be a bit more involved as we thought, as we're missing the projection information of the currently selected layer.

First PR is easy to fix, second less easy, hence I'd like to suggest splitting the PR

@mfisher87
Copy link
Member Author

Great call. Let's leave this PR as a draft and create a new PR for removing reprojection support from the buffer op.

@arjxn-py
Copy link
Member

Sounds Good to me too

@mfisher87
Copy link
Member Author

#563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamically Display Projection Units in Buffer Distance Field
3 participants