-
Notifications
You must be signed in to change notification settings - Fork 39
Dynamic units in buffer dialog #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mfisher87
wants to merge
25
commits into
geojupyter:main
Choose a base branch
from
mfisher87:dynamic-units
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: martinRenou <[email protected]>
Units are calculated from projection, which is currently hard-coded. We instead want to find the projection from the layer, but don't know how yet!
@mfisher87 @arjxn-py @kpdavi what would you think of splitting this PR in two?
First PR is easy to fix, second less easy, hence I'd like to suggest splitting the PR |
Great call. Let's leave this PR as a draft and create a new PR for removing reprojection support from the buffer op. |
Sounds Good to me too |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes all changes from #544; rebase after merge. I did this because to show this PR in this repo, I needed to target a branch in this repo, not a branch on Arjun's fork.
Resolves #541
Checklist
Resolves #XXX
.Failing lint checks can be resolved with:
pre-commit run --all-files
jlpm run lint
📚 Documentation preview: https://jupytergis--554.org.readthedocs.build/en/554/
💡 JupyterLite preview: https://jupytergis--554.org.readthedocs.build/en/554/lite