[WIP] Add GISDocument.path attribute
#631
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s()` We now create untitled documents when no path is passed in, so users can use the JupyterLab facilities to rename the document.
mfisher87
added
enhancement
|
|
mfisher87
changed the title
GISDocument.path attribute
|
Integration tests report: appsharing.space |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Important
Depends on #630. Merge it first, then rebase this PR.
Will resolve #629
I'm attempting to get a
GISDocument.pathattribute. This requires the JS to communicate with Python, because thenewUntitled()method dynamically calculates a filename.I got a rough implementation of the Python side, but I'm struggling to understand where on the JS side I can access
comm.send(...). It seems obvious I should be doing this innotebookrenderer.tsbut I explored so many objects looking forcommand came up empty 🙃 Moving on to something else for now.A little hand-holding would be wonderful, and I'll document what you teach me 🙇 Perhaps that documentation could live in the ypywidgets repository. @davidbrochart what do you think?
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--631.org.readthedocs.build/en/631/
💡 JupyterLite preview: https://jupytergis--631.org.readthedocs.build/en/631/lite