Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: assorted cleanups in release workflow #467

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Sep 5, 2024

Some small follow-ups on #466:

  • In shapely, we noticed that when using multiple docker images in a single job (through a matrix parametrization), only one of the images was cached (and you could see the same here), requiring to specify a scope to get proper caching.
  • When testing, we don't actually need to checkout the source (that also avoids the cd ..)
  • It seemed that the cache was not working for the MacOS x86_64 build. Not sure if that is related to having two jobs on the same macos-12 runner (although they use a unique cache key, so wouldn't expect that), but I saw that vcpkg now has experimental support for directly using the github actions cache (https://learn.microsoft.com/en-us/vcpkg/consume/binary-caching-github-actions-cache), so trying out this option. -> this seems to work only partially .. For the arm build, it only restores cached binaries that are not arm specific (maybe because the runner is actually intel mac, nor arm?)
  • Removing some no longer necessary version restrictions in the requirements-wheel-test.txt file

@@ -3,7 +3,7 @@ set(VCPKG_CRT_LINKAGE dynamic)
set(VCPKG_CMAKE_SYSTEM_NAME Darwin)
set(VCPKG_OSX_ARCHITECTURES arm64)
set(VCPKG_BUILD_TYPE release)
set(VCPKG_OSX_DEPLOYMENT_TARGET "12.0")
set(VCPKG_OSX_DEPLOYMENT_TARGET "14.0")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want this to be our minimum supported version of MacOS, even if we're building on a newer MacOS runner. So this should probably be 13 since 12 is now past EOL.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like MACOSX_DEPLOYMENT_TARGET is getting ignored during the build because it looks like we are building wheels for only >= 14 (per the errors from when repairing the wheel). I don't recall this being an issue before, so it might be that we're not setting this when using the lukka/run-vcpkg@v11 action?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I read that wrong. This is setting 14 as the minimum version we build for, but we were still expecting MACOSX_DEPLOYMENT_TARGET to be 12 in pyproject.toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants