-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD: assorted cleanups in release workflow #467
base: main
Are you sure you want to change the base?
BLD: assorted cleanups in release workflow #467
Conversation
0132cd5
to
fda0205
Compare
d1417a3
to
9212eaa
Compare
9212eaa
to
e66d1f0
Compare
@@ -3,7 +3,7 @@ set(VCPKG_CRT_LINKAGE dynamic) | |||
set(VCPKG_CMAKE_SYSTEM_NAME Darwin) | |||
set(VCPKG_OSX_ARCHITECTURES arm64) | |||
set(VCPKG_BUILD_TYPE release) | |||
set(VCPKG_OSX_DEPLOYMENT_TARGET "12.0") | |||
set(VCPKG_OSX_DEPLOYMENT_TARGET "14.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want this to be our minimum supported version of MacOS, even if we're building on a newer MacOS runner. So this should probably be 13 since 12 is now past EOL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like MACOSX_DEPLOYMENT_TARGET
is getting ignored during the build because it looks like we are building wheels for only >= 14 (per the errors from when repairing the wheel). I don't recall this being an issue before, so it might be that we're not setting this when using the lukka/run-vcpkg@v11
action?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I read that wrong. This is setting 14 as the minimum version we build for, but we were still expecting MACOSX_DEPLOYMENT_TARGET
to be 12 in pyproject.toml
.
Some small follow-ups on #466:
scope
to get proper caching.cd ..
)