Merged
Conversation
b4l
approved these changes
Feb 25, 2026
| results: HashMap<String, InlineOrRefData>, | ||
| }, | ||
| #[schema(value_type = String, format = Binary)] | ||
| Binary(PhantomData<Vec<u8>>), |
Member
There was a problem hiding this comment.
Why is this wrapped in 'PhantomData'?
Contributor
Author
There was a problem hiding this comment.
The Results type is more or less used for the API specs. The logic for serializing binary data cannot be behind a serde enum variant. As such, we indicate a type and do the rest with #[schema].
Having an actual Vec<u8> would result in utoipa to incorrectly say it is a list of int or something.
Member
There was a problem hiding this comment.
Weird, I would expect value_type to be here for that exactly. Maybe this is a shortcoming of utoipa. Maybe a comment would be reasonable here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGES.mdorCHANGELOG.mdFixes:
/jobsin OpenAPI/jobslimit was always at least 100Refactor:
Resultsnow also reflects that the output could be binary