fix demo deps

[michaelkirk]

• I agree to follow the project's code of conduct.
• I added an entry to rstar/CHANGELOG.md if knowledge of this change could be valuable to users.

---

Edit: note this is based on #232 so merge that first.

cargo test / cargo check of the workspace currently fails.

Potentially (?) controversial is adding cargo check (of the demo) to CI. It could be potentially annoying to have the demo block merging of other work. It's also annoying now that I can't run cargo check in the workspace because the demo is broken. 🤷 I'm open to omitting the second commit.

[adamreichold]

Potentially (?) controversial is adding cargo check (of the demo) to CI. It could be potentially annoying to have the demo block merging of other work. It's also annoying now that I can't run cargo check in the workspace because the demo is broken. 🤷 I'm open to omitting the second commit.

I think we deliberately removed it as to not block things on it. I think a more refined position would be a separate job that builds but does not fail the workflow. This way, we notice something breaking early and automatically, but we still do not block anything on these optional components. WDYT?

[michaelkirk]

I've never used these "non-blocking" warning jobs before. It seems kind of useless as is, because there's no indication it failed unless you manually go look at the annotations in https://github.com/georust/rstar/actions/runs/31719804060

Since you brought it up @adamreichold, is there a better way to do this?

[adamreichold]

Since you brought it up @adamreichold, is there a better way to do this?

You added it as a continue-on-error: true step to the existing job. I was thinking of a separate job "workspace check" that just is not considered by the conclusion job and therefore would not fail the overall build. This should then be visible as a separate "check" in the PR overview.

[michaelkirk]

Like this @adamreichold? Otherwise if you have a clear vision of how to do this, please just push something up.

[adamreichold]

Indeed like this, just one nit on the check step.