Expose providerMetadata to usageHandler in RAG component#71
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
Expose providerMetadata to usageHandler in RAG component#71devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
- Add UsageHandler type that accepts providerMetadata from embedding operations - Update createChunkArgsBatch to capture and return providerMetadata from embedMany calls - Call usageHandler in add() method after embeddings are generated - Call usageHandler in search() method when embeddings are generated - Export UsageHandler type for users to import Fixes #60 Co-Authored-By: Ian Macartney <ian@convex.dev>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
commit: |
Contributor
Author
|
Closing due to inactivity for more than 7 days. Configure here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
usageHandlersupport to the RAG component, allowing users to accessproviderMetadatafrom embedding operations. This addresses issue #60 where the RAG component did not exposeproviderMetadatato the usageHandler, unlike the Agent component.Changes include:
UsageHandlertype export that receivesusage,providerMetadata,model, andproviderusageHandlerin RAG constructor optionscreateChunkArgsBatchnow captures and returnsproviderMetadatafromembedMany()callsadd()method at all exit points (ready, replaced, normal completion)search()method when embeddings are generated (requires mutation context)Review & Testing Checklist for Human
search(): The method signature changed fromCtxWith<"runAction">toCtxWith<"runAction"> & Partial<CtxWith<"runMutation">>. Verify this is acceptable and won't break existing callers.ctx.runMutationexists. Confirm this behavior is expected (users calling search from action-only context won't get usage callbacks).providerMetadata(e.g.,gateway.costfor OpenAI) is correctly passed through duringadd()andsearch()operations.Notes
Fixes #60
Link to Devin run: https://app.devin.ai/sessions/d0e570ee532a4881a9d6b5bef478ae46
Requested by: Ian Macartney