-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shoehorn channel-opening flow into first-trade flow #1974
Conversation
8bd7275
to
eceed92
Compare
492ef32
to
5c78048
Compare
The flow looks awesome |
@luckysori Quick question without having looked at the PR yet. Will this change have an impact on the webapp? |
Great question. My intention was to not change the webapp at the moment, but I didn't do it properly. See: https://github.com/get10101/10101/pull/1974/files#diff-8923b602c94d37f595a2e3736668c11f089c092ba9f4774d4b2ce305619c0b35R221. I set the optional |
aa44a29
to
ef790c3
Compare
I think I fixed it now, but I can't test it because I get an SSL error when running the |
abf8941
to
bc852ad
Compare
a828782
to
1f3e843
Compare
Simulator.Screen.Recording.-.iPhone.13.Pro.-.2024-02-10.at.20.58.10.mp4 |
@bonomat @luckysori please have a look at #1974 (comment) and let me know what you think. I took it a bit far (which I probably shouldn't have 🙈), but I got too far to stop now 😅 . |
I think it looks good, although I would make sure the e2e tests pass before merging. I can't seem to find the diff between my version and yours, which is a bit unfortunate. |
a3e6913
to
07581c9
Compare
In particular, how to run the `webapp` with and without TLS. And where to find the website based on that.
07581c9
to
782843e
Compare
run the e2e tests locally! everything passed. going ahead with the merge. |
Fixes #1793.
channel-opening-flow-v0.mp4
TODOs:
submit_channel_opening_order
API.TradeValues
to calculate coordinator margin.TradeConstraints
instead.webapp
if affected.