Display next funding rate below candlestick chart #2613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks better now!
bonomat
reviewed
Jun 6, 2024
It doesn't really fit, even on a bigger phone screen, so it had to be displayed across two rows, which didn't look perfect next to the bid and ask. I don't mind if you propose something else. I only did this because @holzeis really didn't like the original approach. But I think it looks pretty good now. |
|
Happy to leave it for now but I think it is a bit weird to have it in the middle of the screen. Also, I wouldn't have added the text but just the rate. 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @holzeis for the inspiration!