PR #1374 #119
akostylev0codeql
on: dynamic
Matrix: analyze
Annotations
2 warnings
|
hiding a lifetime that's elided elsewhere is confusing:
ton-liteserver-client/src/tracker/masterchain_first_block_tracker.rs#L114
warning: hiding a lifetime that's elided elsewhere is confusing
--> ton-liteserver-client/src/tracker/masterchain_first_block_tracker.rs:114:19
|
114 | pub fn borrow(&self) -> Ref<Option<BlockHeader>> {
| ^^^^^ ------------------------ the same lifetime is hidden here
| |
| the lifetime is elided here
|
= help: the same lifetime is referred to in inconsistent ways, making the signature confusing
= note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
help: use `'_` for type paths
|
114 | pub fn borrow(&self) -> Ref<'_, Option<BlockHeader>> {
| +++
|
|
called `unwrap` on `block` after checking its variant with `is_ok`:
ton-liteserver-client/src/tracker/find_first_block.rs#L46
warning: called `unwrap` on `block` after checking its variant with `is_ok`
--> ton-liteserver-client/src/tracker/find_first_block.rs:46:28
|
45 | if block.is_ok() {
| ---------------- help: try: `if let Ok(<item>) = &block`
46 | success = Some(block.as_ref().unwrap().clone());
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
= note: `#[warn(clippy::unnecessary_unwrap)]` on by default
|