Treat untested manual servers as normal#8875
Open
atavism wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the explicit “Testing…” UI state (spinner and label) for manual Lantern server locations that have not yet received probe results, so those untested locations render like normal (unless they are explicitly probed-unreachable).
Changes:
- Removed the “testing” spinner indicator from manual server selection rows and the Location setting tile UI.
- Deleted the
ServerTestingIndicatorwidget and removed its common export and English localization string. - Updated server availability model/test wording to describe the unprobed state as “unknown” (while keeping probe-state behavior unchanged).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/core/models/available_servers_test.dart | Updates test names/comments to reflect “unknown” wording for unprobed servers. |
| lib/features/vpn/single_city_server_view.dart | Removes the trailing “testing” spinner from the city server tile. |
| lib/features/vpn/server_selection.dart | Removes the “testing” spinner from the country/city server list rows. |
| lib/features/vpn/location_setting.dart | Removes the “Testing…” subtitle and indicator from the selected location setting tile. |
| lib/core/widgets/server_testing_indicator.dart | Deletes the spinner widget implementation. |
| lib/core/models/available_servers.dart | Updates documentation/comments around how unprobed servers are treated. |
| lib/core/common/common.dart | Removes the export for the deleted ServerTestingIndicator. |
| assets/locales/en.po | Removes the server_testing translation entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the visible “Testing…” spinner/state for manual server locations that have not received probe results yet