Skip to content

Allow closing failed access review campaigns#1418

Draft
gearnode wants to merge 1 commit into
mainfrom
cursor/allow-close-failed-access-review-campaign-c8c4
Draft

Allow closing failed access review campaigns#1418
gearnode wants to merge 1 commit into
mainfrom
cursor/allow-close-failed-access-review-campaign-c8c4

Conversation

@gearnode

@gearnode gearnode commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Enable campaign completion based on the backend pending-entry count.
  • Allow campaigns with failed or empty source fetches to complete when no entries remain pending.

Verification

  • make relay
  • npm -w @probo/console run check

Note: npm ci completed with engine warnings because this workspace has Node 22.14.0 while the repo requests Node 24.

Linear Issue: ENG-538

Open in Web Open in Cursor 

Summary by cubic

Lets users complete access review campaigns when source fetch failed or returned no entries. Uses the backend pendingEntryCount to decide completion, satisfying ENG-538.

App: console +3 -8

  • Query now requests pendingEntryCount and derives canComplete from it.
  • Replaces allDecided check and button disable logic to use pending count, enabling completion when pendingEntryCount === 0 even if sources failed or are empty.

Written for commit c6d9b34. Summary will update on new commits.

Review in cubic

Signed-off-by: Cursor Agent <cursoragent@cursor.com>

Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants