PostgreSQL: allow connection parameters to be specified #7579
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eradman
force-pushed
the
libpq-connect-options
branch
from
04a9886 to
a8d5d96
Compare
eradman
changed the title
Contributor
yoshiokatsuneo
left a comment
yoshiokatsuneo
left a comment
There was a problem hiding this comment.
Thank you for the PR !
redash/query_runner/pg.py
Outdated
|
|
||
| def _libpq_params(configuration): | ||
| standard_params = {"user", "password", "host", "port", "dbname"} | ||
| params = psycopg2.extensions.parse_dsn(configuration.get("libpq_params", "")) |
Contributor
There was a problem hiding this comment.
I just feel it is more natural to set configuration name to like "connection_string" (or "dsn"? ) instead of "libpq_params", as that is the string set in the configuration and passed to the parse_dsn function. How do you feel ?
https://www.psycopg.org/docs/extensions.html#psycopg2.extensions.parse_dsn
Collaborator
Author
There was a problem hiding this comment.
Adjusted to use the name "dsn"--this name probably is the best because it suggests the format this string should use.
As documented in https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-PARAMKEYWORDS Multiple parameters are separated by a space.
eradman
force-pushed
the
libpq-connect-options
branch
from
a8d5d96 to
8b4929a
Compare
yoshiokatsuneo
approved these changes
Nov 26, 2025
Contributor
yoshiokatsuneo
left a comment
yoshiokatsuneo
left a comment
There was a problem hiding this comment.
Thank you!
I confirmed that I can connect to PostgreSQL of Redash without problem.
eradman
added a commit
to StarfishStorage/redash
that referenced
this pull request
Nov 26, 2025
As documented in https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-PARAMKEYWORDS Multiple parameters are separated by a space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Allow extra PostgreSQL connection parameters to be specified, as documented in
https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-PARAMKEYWORDS
Multiple parameters are separated by a space.
How is this tested?
Related Tickets & Documents
#7578
Mobile & Desktop Screenshots/Recordings (if there are UI changes)